Fix chip test cleanup hanging problem #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccruzagralopes
requested review from
rquidute,
fabiowmm,
antonio-amjr and
hiltonlima
antonio-amjr
approved these changes
Nov 29, 2023
hiltonlima
approved these changes
Nov 29, 2023
rquidute
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The chip server is not stopping and TH is hanging while waiting for the process to exit.
Comment
This line had been added recently and I'm reverting it for now, since destroying the container will stop the server anyway. Later, I'll update the stop method to do it in another way that I've found that works.
Testing
I've run a
CHIP_TOOLand aCHIP_APPtest and they both finished the cleanup without hanging.